feat(app): add analytics for localization feature #17130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
LGTM. Are we concerned with potentially double reporting these events ever? If so, we might need some sort of
transactionId(as an idempotency key).
You mean like if a user repeatedly swaps the radio button back and forth in one modal/setting view? I think that could still give us useful information, but I'll ask Anthony if he'd prefer an additional key!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix EXEC-1028
Overview
This Pr adds four events for tracking the localization feature
Test Plan and Hands on Testing
Changelog
Review requests
Look over the events for naming and property clarity
Risk assessment
Low, analytics events only